Fixed clippy lint errors (needless_pass_by_ref_mut) (#517)
* Fixed clippy lint errors (needless_pass_by_ref_mut)
* Fixed clippy lint errors (unnecessary_mut_passed)
(cherry picked from commit 897487810d480c47e5e80a3a0c181f1c5976c618)
7303e42620c9078f46cd0090f6b85e45b399ad4c · by Yurii Nakonechnyi · (3 years ago) · parent f58f642fa · browse the tree at this commit
Semantic delta · 8
src/compute/grid/track_sizing.rs
src/compute/grid/types/grid_item.rs
diff --git a/src/compute/flexbox.rs b/src/compute/flexbox.rs
index c72416232..5fa20ccc1 100644
--- a/src/compute/flexbox.rs
+++ b/src/compute/flexbox.rs
@@ -352,7 +352,7 @@ fn compute_preliminary(
// 15. Determine the flex container’s used cross size.
#[cfg(feature = "debug")]
NODE_LOGGER.log("determine_container_cross_size");
- let total_line_cross_size = determine_container_cross_size(&mut flex_lines, known_dimensions, &mut constants);
+ let total_line_cross_size = determine_container_cross_size(&flex_lines, known_dimensions, &mut constants);
// We have the container size.
// If our caller does not care about performing layout we are done now.
@@ -1436,7 +1436,7 @@ fn handle_align_content_stretch(flex_lines: &mut [FlexLine], node_size: Size<Opt
///
/// **Note that this step does not affect the main size of the flex item, even if it has an intrinsic aspect ratio**.
#[inline]
-fn determine_used_cross_size(tree: &mut impl LayoutTree, flex_lines: &mut [FlexLine], constants: &AlgoConstants) {
+fn determine_used_cross_size(tree: &impl LayoutTree, flex_lines: &mut [FlexLine], constants: &AlgoConstants) {
for line in flex_lines {
let line_cross_size = line.cross_size;
@@ -1595,7 +1595,7 @@ fn resolve_cross_axis_auto_margins(flex_lines: &mut [FlexLine], constants: &Algo
/// if neither of the item's cross-axis margins are `auto`.
#[inline]
fn align_flex_items_along_cross_axis(
- child: &mut FlexItem,
+ child: &FlexItem,
free_space: f32,
max_baseline: f32,
constants: &AlgoConstants,
@@ -1653,7 +1653,7 @@ fn align_flex_items_along_cross_axis(
#[inline]
#[must_use]
fn determine_container_cross_size(
- flex_lines: &mut [FlexLine],
+ flex_lines: &[FlexLine],
node_size: Size<Option<f32>>,
constants: &mut AlgoConstants,
) -> f32 {
diff --git a/src/compute/grid/track_sizing.rs b/src/compute/grid/track_sizing.rs
index a1fa6db78..704402518 100644
--- a/src/compute/grid/track_sizing.rs
+++ b/src/compute/grid/track_sizing.rs
@@ -108,7 +108,7 @@ where
/// Compute the item's resolved margins for size contributions. Horizontal percentage margins always resolve
/// to zero if the container size is indefinite as otherwise this would introduce a cyclic dependency.
#[inline(always)]
- fn margins_axis_sums_with_baseline_shims(&self, item: &mut GridItem) -> Size<f32> {
+ fn margins_axis_sums_with_baseline_shims(&self, item: &GridItem) -> Size<f32> {
item.margins_axis_sums_with_baseline_shims(self.inner_node_size.width)
}
@@ -502,7 +502,7 @@ fn resolve_intrinsic_track_sizes(
tree: &mut impl LayoutTree,
axis: AbstractAxis,
axis_tracks: &mut [GridTrack],
- other_axis_tracks: &mut [GridTrack],
+ other_axis_tracks: &[GridTrack],
items: &mut [GridItem],
axis_available_grid_space: AvailableSpace,
inner_node_size: Size<Option<f32>>,
diff --git a/src/compute/grid/types/grid_item.rs b/src/compute/grid/types/grid_item.rs
index 513038d2f..510a420a3 100644
--- a/src/compute/grid/types/grid_item.rs
+++ b/src/compute/grid/types/grid_item.rs
@@ -207,7 +207,7 @@ impl GridItem {
/// allow percentage sizes further down the tree to resolve properly in some cases
fn known_dimensions(
&self,
- tree: &mut impl LayoutTree,
+ tree: &impl LayoutTree,
inner_node_size: Size<Option<f32>>,
grid_area_size: Size<Option<f32>>,
) -> Size<Option<f32>> {
diff --git a/src/compute/leaf.rs b/src/compute/leaf.rs
index 6f95145db..a884bc16f 100644
--- a/src/compute/leaf.rs
+++ b/src/compute/leaf.rs
@@ -43,7 +43,7 @@ impl LayoutAlgorithm for LeafAlgorithm {
/// Compute the size of a leaf node (node with no children)
pub(crate) fn compute(
- tree: &mut impl LayoutTree,
+ tree: &impl LayoutTree,
node: Node,
known_dimensions: Size<Option<f32>>,
parent_size: Size<Option<f32>>,